Timeline for Buffer opened when compiling succeeds
Current License: CC BY-SA 4.0
12 events
| when toggle format | what | by | license | comment | |
|---|---|---|---|---|---|
| Jul 28, 2020 at 4:50 | comment | added | BaRud | So what are the option against statusline? | |
| Jul 27, 2020 at 16:21 | comment | added | B Layer | LOL, well it came off that way to me since it says @BLayer....but no worries. :) | |
| Jul 27, 2020 at 16:20 | comment | added | D. Ben Knoble♦ | @BLayer message not really intended for you :) sorry it came off that way | |
| Jul 27, 2020 at 16:11 | comment | added | B Layer | @D.BenKnoble That really has nothing to do with coding conventions. I was talking about refactoring the conditionals. I mentioned their use of statusline...for which I rendered no judgement...just to identify the code in question. | |
| Jul 27, 2020 at 13:38 | history | edited | D. Ben Knoble♦ | CC BY-SA 4.0 |
deleted 36 characters in body; edited title
|
| Jul 27, 2020 at 13:34 | comment | added | D. Ben Knoble♦ | Other code comment: when you save the old makeprg, you dont restore it. And the double quotes around it arent necessary—just save it directly. | |
| Jul 27, 2020 at 13:33 | comment | added | D. Ben Knoble♦ | @BLayer from a good coding convention standpoint i would recommend not setting the statusline... most users have their own, and I would not be happy if a plugin overrode mine. There are other ways to message the user. (Also the statusline may not be visible) | |
| Jul 27, 2020 at 8:02 | vote | accept | BaRud | ||
| Jul 27, 2020 at 7:29 | answer | added | statox | timeline score: 1 | |
| Jul 27, 2020 at 6:58 | comment | added | B Layer |
BTW, not related to your question but just from a good coding convention standpoint it would be good to change that first if to check the opposite condition and if true set status line to "up to date" and return. Then the rest of the code wouldn't have to all be indented in a large if block.
|
|
| Jul 27, 2020 at 6:50 | comment | added | B Layer |
From what I see in the main function you're always opening the quickfix window except in the case of the obj file being "up to date". Why not just return after the "Compiled succesfully" message?
|
|
| Jul 27, 2020 at 6:34 | history | asked | BaRud | CC BY-SA 4.0 |