Function to toggle set colorcolumn

Question

I like the set colorcolumn=80 option which highlights the column at 80 characters, however I find it annoying when working with multiple split windows.

I'd like to have an option to enable or disable the colored column by using the <leader>c shortcut. I wrote a function, however my Vimscript knowledge is very limited. My only question is do you see anything wrong with this function or approach? or should I go with it?

" Show a colored column at 80 characters
function! ColorColumn()
if &colorcolumn == ""
    set colorcolumn=80
else
    set colorcolumn=
endif
endfunction

nmap <silent> <leader>c :call ColorColumn()<CR>

Answer 1

The only big flaw I see in your code is the fact that you don't use the non recursive version of nmap (See here for more details).

Also just for the sake to not use a function and make it a one liner I came up with this mapping which should do the same job:

nnoremap <leader>c :execute "set colorcolumn=" . (&colorcolumn == "" ? "80" : "")<CR>

We use execute to execute the command created on the fly and a ternary expression to return "" or 80 depending on the current state of colorcolumn

Edit

If you really want to keep it under 80 characters you could use something like this:

nnoremap <silent> <leader>c :execute "set colorcolumn="
                  \ . (&colorcolumn == "" ? "80" : "")<CR>

But I think it's less readable than the one line version.